-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[github] Tweak PR template #20381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[github] Tweak PR template #20381
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,19 @@ | ||
| | Q | A | ||
| | ------------- | --- | ||
| | Branch? | "master" for new features / 2.7, 2.8 or 3.1 for fixes | ||
| | Branch? | master / 2.7, 2.8, 3.1 or 3.2 <!--see comment below--> | ||
| | Bug fix? | yes/no | ||
| | New feature? | yes/no | ||
| | BC breaks? | yes/no | ||
| | Deprecations? | yes/no | ||
| | Tests pass? | yes/no | ||
| | Fixed tickets | comma-separated list of tickets fixed by the PR, if any | ||
| | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | ||
| | License | MIT | ||
| | Doc PR | reference to the documentation PR, if any | ||
| | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> | ||
|
|
||
| <!-- | ||
| - Bug fixes must be submitted against the lowest branch where they apply | ||
| (lowest branches are regularly merged to upper ones so they get the fixes too). | ||
| - Features and deprecations must be submitted against the master branch. | ||
| - Please fill in this template according to the PR you're about to submit. | ||
| - Replace this comment by a description of what your PR is solving. | ||
| --> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would wrapping the placeholders in a comment be relevant, in order to simply have to type value in front of it, instead of removing the whole thing everytime ?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad idea IMHO: makes more things to remove, both for newcomers and oldcomers. And failling to remove the surrounding
<!-- -->will make the field blank. And you know this will happen :)Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for removing it actually. Having this as a comment (as for the top comment you added in this PR) allows to simply keep it, and just type the value in front of it.
Having the field blank by mistake is probably not worse than having the full placeholder displayed 😅
(but as for the top comment, it'll appear in the merge commit description :/)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about moving the top comment below then ?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wild idea: use github's base branch, drop this field and mention the supported branches with a comment...