Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[PhpUnitBridge] Fix undefined variable #20334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2016

Conversation

romainneutron
Copy link
Contributor

Q A
Branch? 3.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT

Otherwise $mode is not defined on line 115

Otherwise `$mode` is not defined on line 115
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Oct 28, 2016

The var line 115 will always be defined, there isn't any bug here to me.
Anyway, 👍 for the readability improvement then ;)

@romainneutron
Copy link
Contributor Author

romainneutron commented Oct 28, 2016

Woops !
Actually the bug is in 3.2... I've digged in the previous versions a bit too fast.
if you look in 3.2, there is a bug because of a third condition placed just before $mode computation

@nicolas-grekas
Copy link
Member

Thank you @romainneutron.

@nicolas-grekas nicolas-grekas merged commit c4cc392 into symfony:3.1 Oct 28, 2016
nicolas-grekas added a commit that referenced this pull request Oct 28, 2016
This PR was merged into the 3.1 branch.

Discussion
----------

[PhpUnitBridge] Fix undefined variable

| Q             | A
| ------------- | ---
| Branch?       | 3.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT

Otherwise `$mode` is not defined on line 115

Commits
-------

c4cc392 [PhpUnitBridge] Fix undefined variable
@romainneutron romainneutron deleted the fix-undefined-variable branch October 28, 2016 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.