Instead of trying to make it work, I suggest trying to make it fail properly. This never worked, so we're not going to break anything.

Agree with @nicolas-grekas

@fancyweb Can you work on a fix based on @nicolas-grekas suggestion?

Ok I will make a new PR. I was waiting for more opinions on this.

What do you think of simply throwing an Exception in the RouteCompiler when the regex is computed ? Maybe new Exception like ParameterNameTooLongException ? I could also update the doc to warn about this.

Instead of trying to make it work, I suggest trying to make it fail properly. This never worked, so we're not going to break anything.

This seems like a really weak argument to me. Because it never worked, lets not improve anything? There are legitimate reasons to want more than 32 characters, such as prefixes in large code-bases, following conventions etc. Increasing the limit brings nothing but advantages. A quick google search will bring up quite a few results, meaning this is an actual issue that people are facing.

Thanks for your improvement fancyweb, I will use your solution in the meantime.

@ryan-senn If you can provide a good example (actual route paths) it maybe possible this can be reconsidered. Looking at the generated result it doesn't seem to affect code or performance under normal conditions (names <32 chars).

But I would vote for a better naming system as variableAlias1 is not really helpful for debugging 😜 rather something like shortest_possible_name_1 so you can still have an idea were it's related to. And more tests are needed as the PhpDumper as no tests for this specific situation.

@sstok I actually found this problem with real route paths that are very long because of my own convention that consist of using the full entity name as the placeholder name in my route.

For instance, in one big project I have the entity SupplierMarkingStaticVariablePriceHolder (40 characters).
I would like to use the following route path : /supplier-marking-static-variable-price-holder/{supplierMarkingStaticVariablePriceHolderId}/supplier-marking-static-variable-price/new
But I have to use : /supplier-marking-static-variable-price-holder/{sMStaticVariablePriceHolderId}/supplier-marking-static-variable-price/new

Currently, this project has 619 routes and I would like all of them to follow the same convention for clarity and clean / logic code, but with the 32 characters limit, the convention cannot be respected : it breaks the project logic.

I know that my convention is not THE convention, but as @ryan-senn said, supporting more than 32 characters will only bring advantages.

That seems like a valid use-case, but I'm not able to vote 😜 If performance for the "old" situation is not affected I think it's reasonable to accept this.