Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[DependencyInjection] merge tags instead of completely replacing them #20278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2016

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Oct 23, 2016

Q A
Branch? 2.7
Bug fix? yes
New feature? yes/no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #20150, #20207
License MIT
Doc PR

In #20207, I missed the array_merge() call. Thus, previously set tags of the decorating service would have been discarded by the compiler pass.

@chalasr
Copy link
Member

chalasr commented Oct 23, 2016

Status: reviewed

👍

@fabpot
Copy link
Member

fabpot commented Oct 23, 2016

Thank you @xabbuh.

@fabpot fabpot merged commit c333eb7 into symfony:2.7 Oct 23, 2016
fabpot added a commit that referenced this pull request Oct 23, 2016
…lacing them (xabbuh)

This PR was merged into the 2.7 branch.

Discussion
----------

[DependencyInjection] merge tags instead of completely replacing them

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | yes/no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20150, #20207
| License       | MIT
| Doc PR        |

In #20207, I missed the `array_merge()` call. Thus, previously set tags of the decorating service would have been discarded by the compiler pass.

Commits
-------

c333eb7 merge tags instead of completely replacing them
@xabbuh xabbuh deleted the pr-20207 branch October 23, 2016 17:59
This was referenced Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.