[DependencyInjection] A decorated service should not keep the autowiring types #20267
Conversation
549eb14 to
3289181
Compare
3289181 to
01d4383
Compare
|
Status: Reviewed 👍 |
|
This patch is for parent/child definitions. Do we have the same issue for service decoration (as handled in the |
|
@xabbuh This patch concerns service decoration, not parent/child (abstract services). In fact the Here we are explicitly ignoring abstract services, because only decorated services (corresponding to Applying this patch to parent/child definitions (removing autowiring types from the abstract parent def) would mean that only the first child of the abstract service inherit the autowiring types, that is not what we want. Note that this issue is very specific to autowiring types. |
5343373 to
a1b0814
Compare
|
Failed builds are unrelated (Twig). |
| @@ -57,6 +57,7 @@ public function process(ContainerBuilder $container) | ||
| $public = $decoratedDefinition->isPublic(); | ||
| $decoratedDefinition->setPublic(false); | ||
| $decoratedDefinition->setTags(array()); | ||
| $decoratedDefinition->setAutowiringTypes(array()); |
There was a problem hiding this comment.
I think we should first add the old value to the decorating service. What do you think?
| @@ -142,6 +142,25 @@ public function testProcessMovesTagsFromDecoratedDefinitionToDecoratingDefinitio | ||
| $this->assertEquals(array('name' => 'bar'), $container->getDefinition('baz')->getTags()); | ||
| } | ||
|
|
||
| public function testDecoratedServiceLoosesAutowiringTypes() |
c43301e to
963d0c5
Compare
963d0c5 to
5951378
Compare
|
Thank you @chalasr. |
…the autowiring types (chalasr) This PR was merged into the 2.8 branch. Discussion ---------- [DependencyInjection] A decorated service should not keep the autowiring types | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20260 (comment) | License | MIT | Doc PR | n/a When decorating a service which is not abstract and has `autowiring_types`, the decorator should be the one used for autowiring methods of autowired services, so we should explicitly empty them on the decorated definition after merged them into the child. See #20260 (comment) for a use case where we are forced to manually empty the decorated service's `autowiring_types`. Commits ------- 5951378 A decorated service should not keep the autowiring types
When decorating a service which is not abstract and has
autowiring_types, the decorator should be the one used for autowiring methods of autowired services, so we should explicitly empty them on the decorated definition after merged them into the child. See #20260 (comment) for a use case where we are forced to manually empty the decorated service'sautowiring_types.