Use UUID for error codes for Form validator. #20011
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7a9e533 to
0b0479c
Compare
fabpot
reviewed
Sep 21, 2016
| 2.8.12 | ||
| ----- | ||
|
|
||
| * [BC BREAK] Changed values of the Symfony\Component\Form\Extension\Validator\Constraints\Form constants. |
There was a problem hiding this comment.
We cannot have a BC break in a patch release. Is it really a BC break? People MUST use the constant anyway, not the value.
There was a problem hiding this comment.
Ok, so can I just remove [BC BREAK] from the changelog?
There was a problem hiding this comment.
You should remove everything here :) Changelogs for patch versions are generated automatically.
0b0479c to
3693e83
Compare
|
👍 |
|
Thank you @Koc. |
fabpot
added a commit
that referenced
this pull request
Sep 21, 2016
This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #20011). Discussion ---------- Use UUID for error codes for Form validator. | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | tiny, but it allowed http://symfony.com/doc/current/contributing/code/bc.html#changing-classes | Deprecations? | no | Tests pass? | I hope so :) | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 6dbb186 Use UUID for error codes for Form validator.
|
@fabpot I've choosen 2.8 branch because uuid codes was added in 2.8, not in 2.7 |
|
See #15154 for details |
|
I agree with @Koc. We should revert the merge on the |
|
Oops, sorry about that. Going to fix that now. |
|
Done |
fabpot
added a commit
that referenced
this pull request
Sep 21, 2016
* 2.7: Revert "minor #20011 Use UUID for error codes for Form validator. (Koc)" Use UUID for error codes for Form validator. Fixed regression when exception message swallowed when logging it. [HttpFoundation] Enable memcached tests with the latest memcached extension
fabpot
added a commit
that referenced
this pull request
Sep 21, 2016
This PR was merged into the 2.8 branch. Discussion ---------- Use UUID for error codes for Form validator. | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | tiny, but it allowed http://symfony.com/doc/current/contributing/code/bc.html#changing-classes | Deprecations? | no | Tests pass? | I hope so :) | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 3693e83 Use UUID for error codes for Form validator.
fabpot
added a commit
that referenced
this pull request
Sep 21, 2016
* 2.8: [VarDumper] Fix test Revert "minor #20011 Use UUID for error codes for Form validator. (Koc)" Use UUID for error codes for Form validator. Use UUID for error codes for Form validator. Fixed regression when exception message swallowed when logging it. [HttpFoundation] Enable memcached tests with the latest memcached extension
fabpot
added a commit
that referenced
this pull request
Sep 21, 2016
* 3.1: [VarDumper] Fix test Revert "minor #20011 Use UUID for error codes for Form validator. (Koc)" Use UUID for error codes for Form validator. Use UUID for error codes for Form validator. Fixed regression when exception message swallowed when logging it. [HttpFoundation] Enable memcached tests with the latest memcached extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.