[FrameworkBundle] Check for class existence before is_subclass_of #19842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52fb4de to
f13d082
Compare
| @@ -38,6 +39,10 @@ public function process(ContainerBuilder $container) | ||
|
|
||
| $class = $container->getParameterBag()->resolveValue($definition->getClass()); | ||
| if (!is_subclass_of($class, 'Symfony\\Component\\Console\\Command\\Command')) { | ||
| if (!class_exists($class, false)) { | ||
| throw new InvalidArgumentException(sprintf('Class "%s" used for service "%s" cannot be found.', $class, $id)); |
There was a problem hiding this comment.
we should use \InvalidArgumentException for consistency in this PR (and rely on your other PR to use "DI" exceptions)
There was a problem hiding this comment.
I thought the inverse would be easier, change done
f13d082 to
8a9e0f5
Compare
|
👍 |
|
Thank you @chalasr. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 6, 2016
…lass_of (chalasr) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] Check for class existence before is_subclass_of | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Same as #19342 Commits ------- 8a9e0f5 [FrameworkBundle] Check for class existence before is_subclass_of
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #19342