[HttpFoundation] fixed Request::getContent() reusage bug #19549
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After calling
Request::getContent(true)
, subsequent calls to thesame instance method (withouth the
$asResource
flag) always returnedfalse
instead of the request body as a plain string.A unit test already existed to guard against this behaviour (the 'Resource then fetch' case) but it
yielded a false positive because it was comparing
''
tofalse
usingPHPUnit's
assertEquals
method instead ofassertSame
.For completeness sake I also added the missing usage permutations in
the data provider, which already worked OK.