[PropertyInfo] Fix array caching

`null` values aren't cached because of the use of `isset`
symfony · GuilhemN · Jul 26, 2016 · Jul 27, 2016 · Jul 29, 2016 · 7bc58bf1c5e2388681f681040e8251657fc248e2
commit 7bc58bf1c5e2388681f681040e8251657fc248e2
diff --git a/src/Symfony/Component/PropertyInfo/PropertyInfoCacheExtractor.php b/src/Symfony/Component/PropertyInfo/PropertyInfoCacheExtractor.php
@@ -108,7 +108,7 @@ private function extract($method, array $arguments)

        $key = $this->escape($method.'.'.$serializedArguments);

-        if (isset($this->arrayCache[$key])) {
+        if (array_key_exists($key, $this->arrayCache)) {
            return $this->arrayCache[$key];
        }


diff --git a/src/Symfony/Component/PropertyInfo/Tests/Fixtures/NullExtractor.php b/src/Symfony/Component/PropertyInfo/Tests/Fixtures/NullExtractor.php
@@ -79,7 +79,7 @@ public function getProperties($class, array $context = array())
    private function assertIsString($string)
    {
        if (!is_string($string)) {
-            throw new \Exception(sprintf('"%s" expects strings, given "%s".', __CLASS__, gettype($string)));
+            throw new \InvalidArgumentException(sprintf('"%s" expects strings, given "%s".', __CLASS__, gettype($string)));
        }
    }
 }