[2.8] [HttpFoundation] HttpCache refresh stale responses containing an ETag #19391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maennchen
commented
Jul 20, 2016
| Q | A |
|---|---|
| Branch? | 2.8 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #19390 |
| License | MIT |
| Doc PR |
| @@ -600,6 +600,9 @@ protected function lock(Request $request, Response $entry) | ||
| */ | ||
| protected function store(Request $request, Response $response) | ||
| { | ||
| if (!$response->headers->has('Date')) { |
There was a problem hiding this comment.
I wanted to explicitly call setDate to clarify what the code is doing even though one line containing the following would have the same effect:
$response->getDate();|
Shouldn't this go into 2.7? |
|
I've never conrtibuted to symfony core before and I'm not sure how the merging will go. |
|
Replaced by #19397 |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 25, 2016
…ontaining an ETag (maennchen) This PR was merged into the 2.7 branch. Discussion ---------- [2.7] [HttpFoundation] HttpCache refresh stale responses containing an ETag | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? |no | BC breaks? |no | Deprecations? |no | Tests pass? | yes | Fixed tickets | #19390, #6746 | License | MIT | Doc PR | This PR is the replacement of #19391, which points at the wrong branch. Commits ------- 96df6b9 [HttpFoundation] HttpCache refresh stale responses containing an ETag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.