Make the exception message more clear. #19310
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,7 +39,7 @@ class PropertyMetadata extends MemberMetadata | ||
| public function __construct($class, $name) | ||
| { | ||
| if (!property_exists($class, $name)) { | ||
| throw new ValidatorException(sprintf('Property %s does not exist in class %s', $name, $class)); | ||
| throw new ValidatorException(sprintf('Property "%s" does not exist in class %s', $name, $class)); |
There was a problem hiding this comment.
please also wrap the class %s into quotes.
|
big 👍 |
|
👍 @symfony/deciders I suggest including this in patch releases. |
|
Thank you for the lightning fast review. I've quoted the class as well. |
|
👍 |
|
Thank you @Nyholm. |
fabpot
added a commit
that referenced
this pull request
Jul 8, 2016
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #19310). Discussion ---------- Make the exception message more clear. | Q | A | ------------- | --- | Branch? | "master" | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | A small change that makes the error message more clear. If your property is named "type", "value" or something similar it is not obvious that we refer to the property name. See example: schmittjoh/JMSTranslationBundle#373 Commits ------- 6344ccd Make the exception message more clear.
|
Thank you for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change that makes the error message more clear. If your property is named "type", "value" or something similar it is not obvious that we refer to the property name.
See example: schmittjoh/JMSTranslationBundle#373