[Security] fixed DebugAccessDecisionManager::setVoters() #19272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 This check makes much more sense imo Status: reviewed |
|
Tests are failing :( Status: Needs Work |
| @@ -62,7 +62,7 @@ public function decide(TokenInterface $token, array $attributes, $object = null) | ||
| */ | ||
| public function setVoters(array $voters) | ||
| { | ||
| if (!$this->manager instanceof AccessDecisionManager) { | ||
| if (!method_exists($this->voters, 'setVoters')) { |
There was a problem hiding this comment.
Am I missing something or you are calling method_exists on an array?
Should it not be !method_exists($this->manager, 'setVoters') instead?
There was a problem hiding this comment.
Of courses! Went to quickly on this one, thanks!
df4c4b8 to
c1a2a0a
Compare
|
Status: Needs Review |
|
Thank you @HeahDude. |
fabpot
added a commit
that referenced
this pull request
Jul 3, 2016
…HeahDude) This PR was merged into the 3.1 branch. Discussion ---------- [Security] fixed DebugAccessDecisionManager::setVoters() | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | schmittjoh/JMSSecurityExtraBundle#207 | License | MIT | Doc PR | ~ Commits ------- c1a2a0a [Security] fixed DebugAccessDecisionManager::setVoters()
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.