[DoctrineBridge] fixed default parameter value in UniqueEntityValidator #19227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HeahDude
commented
Jun 29, 2016
| Q | A |
|---|---|
| Branch? | 3.1 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #19209 |
| License | MIT |
| Doc PR | ~ |
|
Confirmed by @nicolas-grekas that the remaining failure in |
|
@nicolas-grekas Is that normal that tests pass in high depth in travis? Shouldn't the validator dependency in the doctrine bridge be updated? |
|
Ok I got it, tests are not running on 3.1, so maybe we should add a conflict? |
| @@ -127,6 +127,10 @@ public function validate($entity, Constraint $constraint) | ||
| $errorPath = null !== $constraint->errorPath ? $constraint->errorPath : $fields[0]; | ||
| $invalidValue = isset($criteria[$errorPath]) ? $criteria[$errorPath] : $criteria[$fields[0]]; | ||
|
|
||
| if (is_object($invalidValue) && !method_exists($invalidValue, '__toString')) { | ||
| $invalidValue = sprintf('Object of class "%s" identified by "%s"', get_class($entity), implode(', ', $class->getIdentifierValues($entity))); |
There was a problem hiding this comment.
Why not use this in the default message by including the placeholder?
|
Thank you @HeahDude. |
fabpot
added a commit
that referenced
this pull request
Jun 30, 2016
…tityValidator (HeahDude) This PR was merged into the 3.1 branch. Discussion ---------- [DoctrineBridge] fixed default parameter value in UniqueEntityValidator | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19209 | License | MIT | Doc PR | ~ Commits ------- 40c0c52 [DoctrineBridge] fixed default parameter value in UniqueEntityValidator
|
Tests may fail after #19240, do they? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.