Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Console] removed unneeded private methods #19163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2016
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[Console] removed unneeded private methods
  • Loading branch information
fabpot committed Jun 24, 2016
commit 35f32ebe125a6be691bfc93b1f60efbadbc6cb23
14 changes: 2 additions & 12 deletions 14 src/Symfony/Component/Console/Helper/ProgressBar.php
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,7 @@ private function setMaxSteps($max)
private function overwrite($message)
{
if ($this->overwrite) {
if (!$this->isFirstRun()) {
if (!$this->firstRun) {
// Move the cursor to the beginning of the line
$this->output->write("\x0D");

Expand All @@ -539,7 +539,7 @@ private function overwrite($message)
$this->output->writeln('');
}

$this->setFirstRun(false);
$this->firstRun = false;

$this->output->write($message);
}
Expand Down Expand Up @@ -632,14 +632,4 @@ private static function initFormats()
'debug_nomax' => ' %current% [%bar%] %elapsed:6s% %memory:6s%',
);
}

private function isFirstRun()
{
return $this->firstRun;
}

private function setFirstRun($firstRun)
{
$this->firstRun = (bool) $firstRun;
}
}
Morty Proxy This is a proxified and sanitized view of the page, visit original site.