[Security] [Guard] Improve comment with working example #19142
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * 'password' => $request->request->get('_password'), | ||
| * ); | ||
| * | ||
| * if($request->request->has('_username')) { |
There was a problem hiding this comment.
CS needs a fix: space after if, and else on the same line as } (but is the else required?)
There was a problem hiding this comment.
Sorry again for the CS, I should really forget my old habits and get used to real PSR-2...
For the else I want to emphasis on the fact that you should not forget to return null when you don't have credentials.
|
Thank you @pasdeloup. |
fabpot
added a commit
that referenced
this pull request
Jun 23, 2016
…(pasdeloup) This PR was squashed before being merged into the 2.8 branch (closes #19142). Discussion ---------- [Security] [Guard] Improve comment with working example | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Improve the code given in the comment to make it work. If you follow blindly the previous example (as I did) and never return null, you're stucked in an infinite redirection loop on your login page. Commits ------- b36fc32 [Security] [Guard] Improve comment with working example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the code given in the comment to make it work.
If you follow blindly the previous example (as I did) and never return null, you're stucked in an infinite redirection loop on your login page.