[PhpUnitBridge] use call_user_func() for PHP 5.3 compatibility #19126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all callables can be called directly on PHP 5.3 (for example,
`array('className', 'methodName')` does not work).
|
But Symfony 3.x does not support PHP 5.3 anymore. |
|
No, but we explicitly support PHP 5.3 for the PHPUnit bridge to use the latest version in tests for older Symfony versions for example (see https://github.com/symfony/symfony/blob/master/src/Symfony/Bridge/PhpUnit/composer.json#L19-L21). |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jun 21, 2016
…lity (xabbuh)
This PR was merged into the 3.2-dev branch.
Discussion
----------
[PhpUnitBridge] use call_user_func() for PHP 5.3 compatibility
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Not all callables can be called directly on PHP 5.3 (for example, `array('className', 'methodName')` does not work).
Commits
-------
8549e05 use call_user_func() for PHP 5.3 compatibility
|
À priori 👎
Because no code has yet been written with the 5.3 unsupported style, thus
there is nothing to fix.
|
|
@nicolas-grekas Yeah, but that doesn't mean that someone wants to use this in their own project outside Symfony. Why should we not make their lives easier? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all callables can be called directly on PHP 5.3 (for example,
array('className', 'methodName')does not work).