Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[VarDumper] Add dd function, dump and die #19096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

[VarDumper] Add dd function, dump and die #19096

wants to merge 6 commits into from

Conversation

Mrkisha
Copy link

@Mrkisha Mrkisha commented Jun 18, 2016

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets ~
License MIT
Doc PR ~

Laravel already has this functionality on top of VarDumper. Why not just make it available out of the box?

This is my first ever PR, any guidance and patient is appreciated.

ThomasLandauer and others added 5 commits June 16, 2016 20:42
This PR was merged into the 2.7 branch.

Discussion
----------

Fixed typo in PHPDoc

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes/no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes/no
| Fixed tickets | comma-separated list of tickets fixed by the PR, if any
| License       | MIT
| Doc PR        | reference to the documentation PR, if any

Commits
-------

9e7b347 Fixed typo in PHPDoc
FormBuilderInterface->getForm() should depend on abstractions and
not implementations as a return type.
…orAggregate::getIterator PhpStorm support (Haehnchen)

This PR was merged into the 2.7 branch.

Discussion
----------

add docblock type elements to support newly added IteratorAggregate::getIterator PhpStorm support

| Q             | A
| ------------- | ---
| Branch       | 2.7
| Bug fix      | no
| New feature  | no
| BC breaks    | no
| Deprecations | no
| Tests pass   | yes
| License       | MIT

In additional to #16965 PhpStorm supports `IteratorAggregate::getIterator` now. see https://blog.jetbrains.com/phpstorm/2016/06/phpstorm-2016-2-eap-162-844/

example
```
$collection  = new \Symfony\Component\Routing\RouteCollection();
foreach ($collection as $route) {
    $route->getHost();
}
```

Commits
-------

ede3556 add docblock type elements to support newly added IteratorAggregate::getIterator PhpStorm support
@wouterj
Copy link
Member

wouterj commented Jun 18, 2016

Welcome @Mrkisha! :)

Unfortunately, this feature was requested before (#13657) and rejected, because the core team doesn't see any benefit in these type of shortcuts.

As this is your first contribution, let me give you some tips to make your next contributions even more awesome:

  • Before creating a patch, first use the search functionality on the issue tracker and PR list to see if the feature is requested before. You can also first create an issue to get the opinion, which saves you the time of implementing a rejected feature.
  • New features are always created on master, not on 2.7. It seems like you edited the 2.7 branch directly. Please refer to the Submitting a Patch guide for more information and a step-by-step guide into contribution. (for instance, it's common to create a new branch per PR, so you can submit multiple PRs at the same time)

@Mrkisha
Copy link
Author

Mrkisha commented Jun 18, 2016

Thank you. I appreciate.

This PR was merged into the 2.7 branch.

Discussion
----------

FormBuilderInterface: fix getForm() return type.

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

FormBuilderInterface->getForm() should depend on abstractions and
not implementations as a return type.

Commits
-------

3fa081c FormBuilderInterface: fix getForm() return type.
@nicolas-grekas
Copy link
Member

For reference, this is being reconsidered in #26970.

fabpot added a commit that referenced this pull request Apr 19, 2018
…s-grekas)

This PR was merged into the 4.1-dev branch.

Discussion
----------

[VarDumper] Add dd() helper == dump() + exit()

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

By popular demand, I feel like we should reconsider our refusal for a `dd()` global helper.
For past references, see #26965, #26906, #13657, #17267, #19096.

Commits
-------

a55916a [VarDumper] Add dd() helper == dump() + die()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.