[travis] Don't use parallel on HHVM #18962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e297328 to
7aa93dc
Compare
7aa93dc to
346149e
Compare
|
Eventually ready: by running the full test suite in a single phpunit run, we gain ~2 minutes on the HHVM matrix line. |
|
OK for me if it is faster. 👍 We may be hit by the JIT cost when parallelizing (redoing JIT for the same classes for each component, while doing a single run allows to JIT phpunit classes only once) |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 3, 2016
This PR was merged into the 2.7 branch. Discussion ---------- [travis] Don't use parallel on HHVM | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Targeting a speedup of the HHVM matrix line especially. Commits ------- 346149e [travis] Don't use parallel on HHVM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting a speedup of the HHVM matrix line especially.