Improved the code

symfony · javiereguiluz · Jun 1, 2016 · Jun 2, 2016 · Jun 5, 2016 · Jun 28, 2016
commit 639c8ead203e988ff6125954ab397c4f6989d397
diff --git a/src/Symfony/Component/Security/Core/Authorization/DebugAccessDecisionManager.php b/src/Symfony/Component/Security/Core/Authorization/DebugAccessDecisionManager.php
@@ -33,10 +33,12 @@ public function __construct(AccessDecisionManagerInterface $manager)
    {
        $this->manager = $manager;

-        // The strategy is stored in a private property of the decorated service
-        $reflection = new \ReflectionProperty($manager, 'strategy');
-        $reflection->setAccessible(true);
-        $this->strategy = $reflection->getValue($manager);
+        if ($this->manager instanceof AccessDecisionManager) {
+            // The strategy is stored in a private property of the decorated service
+            $reflection = new \ReflectionProperty(AccessDecisionManager::class, 'strategy');
+            $reflection->setAccessible(true);
+            $this->strategy = $reflection->getValue($manager);
+        }
    }

    /**
@@ -60,6 +62,10 @@ public function decide(TokenInterface $token, array $attributes, $object = null)
     */
    public function setVoters(array $voters)
    {
+        if (!$this->manager instanceof AccessDecisionManager) {
+            return;
+        }
+
        $this->voters = $voters;
        $this->manager->setVoters($voters);
    }
@@ -72,7 +78,7 @@ public function getStrategy()
        // The $strategy property is misleading because it stores the name of its
        // method (e.g. 'decideAffirmative') instead of the original strategy name
        // (e.g. 'affirmative')
-        return strtolower(substr($this->strategy, 6));
+        return null === $this->strategy ? '-' : strtolower(substr($this->strategy, 6));
    }

    /**