[Console][DX] Fixed ambiguous error message when using a duplicate option shortcut #18864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a test covering this to prevent regressions |
|
btw, it may even go into 2.3 (if it is merged in the next few days) |
|
@stof Test just has been added. |
|
|
||
| $application->run($input, $output); | ||
| } | ||
|
|
There was a problem hiding this comment.
Please remove the trailing spaces here.
|
👍 apart from my minor comment Status: Reviewed |
|
Thank you @peterrehm. |
fabpot
added a commit
that referenced
this pull request
May 26, 2016
…uplicate option shortcut (peterrehm) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #18864). Discussion ---------- [Console][DX] Fixed ambiguous error message when using a duplicate option shortcut | Q | A | ------------- | --- | Branch? | 2.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18856 | License | MIT | Doc PR | - I assume this should be merged into 2.3 as per @stof's comment. There is a race condition when you run a command which has a duplicate option shortcut. Simply changing the order so that Options are merged before the Arguments solves that race condition. ````php $this->setName('my:super:command') ->setAliases(['my:super:commandalias']) ->setDescription('Performs some irrelevant work.') ->addOption('survey', 'e', InputOption::VALUE_REQUIRED, 'My option with a shortcut.') ```` Gives the error message: ``` [Symfony\Component\Console\Exception\LogicException] An argument with name "command" already exists. ``` This happens as the first time the definition is merged happens here: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Application.php#L820 As this throws an error here: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Command/Command.php#L309 The commans are merged but not the options. Merging it then again when the command is run https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Command/Command.php#L217 throws an error due to the duplicate argument as the arguments already have been merged. This time the error message is not surpressed and will confuse the user. Changing the order should fix the issue for duplicate arguments as well as for duplicate options. Commits ------- 7cb7655 [Console][DX] Fixed ambiguous error message when using a duplicate option shortcut
Merged
Merged
This was referenced Jun 6, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assume this should be merged into 2.3 as per @stof's comment.
There is a race condition when you run a command which has a duplicate option shortcut. Simply changing the order so that Options are merged before the Arguments solves that race condition.
Gives the error message:
This happens as the first time the definition is merged happens here:
https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Application.php#L820
As this throws an error here:
https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Command/Command.php#L309
The commans are merged but not the options.
Merging it then again when the command is run
https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Command/Command.php#L217
throws an error due to the duplicate argument as the arguments already have been merged. This time the error message is not surpressed and will confuse the user.
Changing the order should fix the issue for duplicate arguments as well as for duplicate options.