[Yaml] chomp newlines only at the end of YAML documents #18828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
May 21, 2016
| Q | A |
|---|---|
| Branch? | 2.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #18784 |
| License | MIT |
| Doc PR |
|
It does fix the issue 👍 |
| @@ -634,6 +643,11 @@ private function isCurrentLineComment() | ||
| return '' !== $ltrimmedLine && $ltrimmedLine[0] === '#'; | ||
| } | ||
|
|
||
| private function isCurrentLineLastLineInDocument() |
There was a problem hiding this comment.
Let's "nitpick" a bit: would isLastDocumentLine() be a better name for isCurrentLineLastLineInDocument()?
There was a problem hiding this comment.
Not sure, we don't pass any argument so it's not really clear to what the method name refers to imo. Note that the isCurrentLine prefix is a common pattern in the parser (e.g. isCurrentLineComment(), isCurrentLineBlank() and so on).
|
👍 Status: reviewed |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
May 23, 2016
…abbuh) This PR was merged into the 2.3 branch. Discussion ---------- [Yaml] chomp newlines only at the end of YAML documents | Q | A | ------------- | --- | Branch? | 2.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18784 | License | MIT | Doc PR | Commits ------- a4b1fa6 chomp newlines only at the end of YAML documents
This was referenced Jun 6, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.