Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[2.3] Fixed DateTimeInterface comparaison #18749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

francisbesset
Copy link
Contributor

Q A
Branch? 2.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

DateTime class implements the DateTimeInterface.
It is useless to compare is a value is an instance of DateTime or DateTimeInterface.

@francisbesset francisbesset changed the title Fixed DateTimeInterface comparaison [2.3] Fixed DateTimeInterface comparaison May 11, 2016
@stloyd
Copy link
Contributor

stloyd commented May 11, 2016

This wrong cause that interface was introduced in PHP 5.5, but Symfony < 3.0 supports PHP 5.3!

@francisbesset
Copy link
Contributor Author

@stloyd good point. I see that for sf3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.