Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[2.8] [Form] Modified iterator_to_array's 2nd parameter to false in ViolationMapper #18747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[2.8] [Form] Modified iterator_to_array's 2nd parameter to false in ViolationMapper #18747

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c866c0
[Form] fixed ViolationMapper bug
issei-m May 10, 2016
cf520b5
[Form] fixed ViolationMapperTest
issei-m May 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[Form] fixed ViolationMapper bug
  • Loading branch information
@issei-m
issei-m committed May 12, 2016
commit 7c866c08806303746c77e1ce2c273f7c6a4d2a4c
8 changes: 3 additions & 5 deletions 8 src/Symfony/Component/Form/Extension/Validator/ViolationMapper/ViolationMapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,7 @@ private function matchChild(FormInterface $form, PropertyPathIteratorInterface $
}
}

$children = iterator_to_array(new \RecursiveIteratorIterator(
new InheritDataAwareIterator($form)
));
$children = iterator_to_array(new \RecursiveIteratorIterator(new InheritDataAwareIterator($form)), false);

while ($it->valid()) {
if ($it->isIndex()) {
Expand All @@ -189,7 +187,7 @@ private function matchChild(FormInterface $form, PropertyPathIteratorInterface $
}

/** @var FormInterface $child */
foreach ($children as $key => $child) {
foreach ($children as $i => $child) {
$childPath = (string) $child->getPropertyPath();
if ($childPath === $chunk) {
$target = $child;
Expand All @@ -198,7 +196,7 @@ private function matchChild(FormInterface $form, PropertyPathIteratorInterface $
continue;
}

unset($children[$key]);
unset($children[$i]);
}

$it->next();
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.