Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

added a conflict between Monolog bridge 2.8 and HTTP Kernel 3.0+ #18705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2016

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented May 4, 2016

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
Fixed tickets n/a
License MIT
Doc PR n/a

Monolog Bridge 2.8 cannot be used with HTTP Kernel 3.0 as the LoggerInterface is not defined anymore. That's a problem for the Silex Skeleton for instance.

@stof
Copy link
Member

stof commented May 4, 2016

technically, this should be added in older 2.x versions too

@fabpot
Copy link
Member Author

fabpot commented May 4, 2016

Yes, but there is no guarantee of compatibility anyway between 2.x (x < 8) and 3.0. That's why I've also forced the Silex skeleton for Silex 1.x to always use HTTP Kernel 2.8.

@nicolas-grekas
Copy link
Member

👍

1 similar comment
@xabbuh
Copy link
Member

xabbuh commented May 6, 2016

👍

@nicolas-grekas
Copy link
Member

Thank you @fabpot.

@nicolas-grekas nicolas-grekas merged commit 59ffd04 into symfony:2.8 May 6, 2016
nicolas-grekas added a commit that referenced this pull request May 6, 2016
…l 3.0+ (fabpot)

This PR was merged into the 2.8 branch.

Discussion
----------

added a conflict between Monolog bridge 2.8 and HTTP Kernel 3.0+

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Monolog Bridge 2.8 cannot be used with HTTP Kernel 3.0 as the LoggerInterface is not defined anymore. That's a problem for the Silex Skeleton for instance.

Commits
-------

59ffd04 added a conflict between Monolog bridge 2.8 and HTTP Kernel 3.0+
This was referenced May 9, 2016
ymc-dabe added a commit to ymc-dabe/symfony that referenced this pull request May 11, 2016
Caused by symfony#18705, it is impossible to install v3.0.6 of symfony/monolog-bridge
together with v3.0.6 of symfony/http-kernel.

The intention of symfony#18705 "added a conflict between Monolog bridge 2.8 and
HTTP Kernel 3.0+" was to prevent installing symfony/monolog-bridge from the
3.0 series with http-kernel from the 2.8 series of symfony. While this now
works correctly in 2.8.6, exactly the opposite behavior was reached for 3.0.6.

This commit resolves this issue.
ymc-dabe added a commit to ymc-dabe/symfony that referenced this pull request May 11, 2016
Caused by symfony#18705, it is impossible to install v3.0.6 of symfony/monolog-bridge
together with v3.0.6 of symfony/http-kernel.

The intention of symfony#18705 "added a conflict between Monolog bridge 2.8 and
HTTP Kernel 3.0+" was to prevent installing symfony/monolog-bridge from the
3.0 series with http-kernel from the 2.8 series of symfony. While this now
works correctly in v2.8.6, it breaks installing symfony/monolog-bridge v3.0.6
with symfony/http-kernel v3.0.6.

This commit resolves this issue.
fabpot added a commit that referenced this pull request May 11, 2016
…ernel in 3.0.6 (ymc-dabe)

This PR was merged into the 3.0 branch.

Discussion
----------

[MonologBridge] Uninstallable together with symfony/http-kernel in 3.0.6

| Q             | A
| ------------- | ---
| Branch?       | 3.0
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Caused by #18705, it is impossible to install v3.0.6 of symfony/monolog-bridge
together with v3.0.6 of symfony/http-kernel.

The intention of #18705 "added a conflict between Monolog bridge 2.8 and
HTTP Kernel 3.0+" was to prevent installing symfony/monolog-bridge from the
3.0 series with http-kernel from the 2.8 series of symfony. While this now
works correctly in v2.8.6, it breaks installing symfony/monolog-bridge v3.0.6
with symfony/http-kernel v3.0.6.

This PR resolves this issue.

# How to reproduce
- Create a test directory and change into it - e.g. with `mkdir /tmp/reproduce-symfony-18745 && cd /tmp/reproduce-symfony-18745`
- Add the following composer.json to this test directory
```
{
   "require": {
     "symfony/monolog-bridge": "3.0.6",
     "symfony/http-kernel": "3.0.6"
  }
}
```
- Run `composer install` from the test directory

## Expected behavior
Composer installs symfony/monolog-bridge and symfony/http-kernel (together with their dependencies).

## Actual behavior
Composer fails with the following error messages:
```
#:/tmp/reproduce-symfony-18745$ composer install
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for symfony/monolog-bridge 3.0.6 -> satisfiable by symfony/monolog-bridge[v3.0.6].
    - symfony/http-kernel v3.0.6 conflicts with symfony/monolog-bridge[v3.0.6].
    - Installation request for symfony/http-kernel 3.0.6 -> satisfiable by symfony/http-kernel[v3.0.6].
```

Commits
-------

72c44c2 [MonologBridge] Uninstallable together with symfony/http-kernel in 3.0.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.