-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
added a conflict between Monolog bridge 2.8 and HTTP Kernel 3.0+ #18705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technically, this should be added in older 2.x versions too |
Yes, but there is no guarantee of compatibility anyway between 2.x (x < 8) and 3.0. That's why I've also forced the Silex skeleton for Silex 1.x to always use HTTP Kernel 2.8. |
👍 |
1 similar comment
👍 |
Thank you @fabpot. |
nicolas-grekas
added a commit
that referenced
this pull request
May 6, 2016
…l 3.0+ (fabpot) This PR was merged into the 2.8 branch. Discussion ---------- added a conflict between Monolog bridge 2.8 and HTTP Kernel 3.0+ | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | n/a | License | MIT | Doc PR | n/a Monolog Bridge 2.8 cannot be used with HTTP Kernel 3.0 as the LoggerInterface is not defined anymore. That's a problem for the Silex Skeleton for instance. Commits ------- 59ffd04 added a conflict between Monolog bridge 2.8 and HTTP Kernel 3.0+
ymc-dabe
added a commit
to ymc-dabe/symfony
that referenced
this pull request
May 11, 2016
Caused by symfony#18705, it is impossible to install v3.0.6 of symfony/monolog-bridge together with v3.0.6 of symfony/http-kernel. The intention of symfony#18705 "added a conflict between Monolog bridge 2.8 and HTTP Kernel 3.0+" was to prevent installing symfony/monolog-bridge from the 3.0 series with http-kernel from the 2.8 series of symfony. While this now works correctly in 2.8.6, exactly the opposite behavior was reached for 3.0.6. This commit resolves this issue.
ymc-dabe
added a commit
to ymc-dabe/symfony
that referenced
this pull request
May 11, 2016
Caused by symfony#18705, it is impossible to install v3.0.6 of symfony/monolog-bridge together with v3.0.6 of symfony/http-kernel. The intention of symfony#18705 "added a conflict between Monolog bridge 2.8 and HTTP Kernel 3.0+" was to prevent installing symfony/monolog-bridge from the 3.0 series with http-kernel from the 2.8 series of symfony. While this now works correctly in v2.8.6, it breaks installing symfony/monolog-bridge v3.0.6 with symfony/http-kernel v3.0.6. This commit resolves this issue.
fabpot
added a commit
that referenced
this pull request
May 11, 2016
…ernel in 3.0.6 (ymc-dabe) This PR was merged into the 3.0 branch. Discussion ---------- [MonologBridge] Uninstallable together with symfony/http-kernel in 3.0.6 | Q | A | ------------- | --- | Branch? | 3.0 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Caused by #18705, it is impossible to install v3.0.6 of symfony/monolog-bridge together with v3.0.6 of symfony/http-kernel. The intention of #18705 "added a conflict between Monolog bridge 2.8 and HTTP Kernel 3.0+" was to prevent installing symfony/monolog-bridge from the 3.0 series with http-kernel from the 2.8 series of symfony. While this now works correctly in v2.8.6, it breaks installing symfony/monolog-bridge v3.0.6 with symfony/http-kernel v3.0.6. This PR resolves this issue. # How to reproduce - Create a test directory and change into it - e.g. with `mkdir /tmp/reproduce-symfony-18745 && cd /tmp/reproduce-symfony-18745` - Add the following composer.json to this test directory ``` { "require": { "symfony/monolog-bridge": "3.0.6", "symfony/http-kernel": "3.0.6" } } ``` - Run `composer install` from the test directory ## Expected behavior Composer installs symfony/monolog-bridge and symfony/http-kernel (together with their dependencies). ## Actual behavior Composer fails with the following error messages: ``` #:/tmp/reproduce-symfony-18745$ composer install Loading composer repositories with package information Updating dependencies (including require-dev) Your requirements could not be resolved to an installable set of packages. Problem 1 - Installation request for symfony/monolog-bridge 3.0.6 -> satisfiable by symfony/monolog-bridge[v3.0.6]. - symfony/http-kernel v3.0.6 conflicts with symfony/monolog-bridge[v3.0.6]. - Installation request for symfony/http-kernel 3.0.6 -> satisfiable by symfony/http-kernel[v3.0.6]. ``` Commits ------- 72c44c2 [MonologBridge] Uninstallable together with symfony/http-kernel in 3.0.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monolog Bridge 2.8 cannot be used with HTTP Kernel 3.0 as the LoggerInterface is not defined anymore. That's a problem for the Silex Skeleton for instance.