-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[HttpKernel] tweaked redirection profiling in RequestDataCollector #18618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@javiereguiluz it happens because of this line https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpKernel/EventListener/ProfilerListener.php#L81. But the scope of I also refactored a bit since Please tell me if the fix works for you too, and thanks again for reporting it :) |
4127b5c
to
a47d2e8
Compare
fixes redirection profile introduced in 0a1b284. Prevents collecting redirect data on sub request profiling.
a47d2e8
to
df19c14
Compare
I reverted the redirect controller thing as I got the wrong result while testing it with Thanks. |
ping @javiereguiluz |
Thank you @HeahDude. |
…ollector (HeahDude) This PR was merged into the 3.1-dev branch. Discussion ---------- [HttpKernel] tweaked redirection profiling in RequestDataCollector | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ - c8ba3b2 removes duplicated code forgotten in #17589 - a47d2e8 fixes the collecting of redirect data in first sub request instead of redirected master request. Commits ------- df19c14 use a request attribute flag for redirection profile b26cb6d [HttpKernel] added RequestDataCollector::onKernelResponse() c8ba3b2 [HttpKernel] remove legacy duplicated code
'status_text' => Response::$statusTexts[(int) $statusCode], | ||
)); | ||
} | ||
if (isset($session)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using isset
on a variable should be avoided. I've fixed it in becdbd9
Uh oh!
There was an error while loading. Please reload this page.