symfony · nicolas-grekas · Apr 19, 2016 · Apr 15, 2016 · xabbuh · Apr 21, 2016
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
@@ -513,7 +513,7 @@ private function addSerializerSection(ArrayNodeDefinition $rootNode)
                    ->canBeEnabled()
                    ->children()
                        ->booleanNode('enable_annotations')->defaultFalse()->end()
-                        ->scalarNode('cache')->end()
+                        ->scalarNode('cache')->defaultValue('serializer.mapping.cache.symfony')->end()
                        ->scalarNode('name_converter')->end()
                    ->end()
                ->end()

diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -982,7 +982,7 @@ private function registerSerializerConfiguration(array $config, ContainerBuilder

        $chainLoader->replaceArgument(0, $serializerLoaders);

-        if (isset($config['cache']) && $config['cache']) {
+        if (!$container->getParameter('kernel.debug')) {
            $container->setParameter(
                'serializer.mapping.cache.prefix',
                'serializer_'.$this->getKernelRootHash($container)

diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/cache_pools.xml b/src/Symfony/Bundle/FrameworkBundle/Resources/config/cache_pools.xml
@@ -25,6 +25,10 @@
            <tag name="cache.pool" clearer="cache.default_pools_clearer" />
        </service>

+        <service id="cache.pool.serializer" parent="cache.adapter.local" public="false">
+            <tag name="cache.pool" clearer="cache.default_pools_clearer" />
+        </service>
+
        <service id="cache.adapter.apcu" class="Symfony\Component\Cache\Adapter\ApcuAdapter" abstract="true">
            <argument /> <!-- namespace -->
            <argument /> <!-- default lifetime -->

diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/serializer.xml b/src/Symfony/Bundle/FrameworkBundle/Resources/config/serializer.xml
@@ -38,6 +38,10 @@
        </service>

        <!-- Cache -->
+        <service id="serializer.mapping.cache.symfony" class="Symfony\Component\Cache\DoctrineProvider" public="false">
+            <argument type="service" id="cache.pool.serializer" />
+        </service>
+
        <service id="serializer.mapping.cache.apc" class="Doctrine\Common\Cache\ApcCache" public="false">
            <call method="setNamespace">
                <argument>%serializer.mapping.cache.prefix%</argument>

diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/ConfigurationTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/ConfigurationTest.php
@@ -221,6 +221,7 @@ protected static function getBundleDefaultConfig()
            'serializer' => array(
                'enabled' => false,
                'enable_annotations' => false,
+                'cache' => 'serializer.mapping.cache.symfony',
            ),
            'property_access' => array(
                'magic_call' => false,
-Original file line number
+Diff line change
@@ -982,7 +982,7 @@ private function registerSerializerConfiguration(array $config, ContainerBuilder
             $chainLoader->replaceArgument(0, $serializerLoaders);
-            if (isset($config['cache']) && $config['cache']) {
+            if (!$container->getParameter('kernel.debug')) {
             Copy link

  
      
    
  

  
      

  
  Member


      

  

  
    
      

      
            xabbuh
  

      

      

      


        Apr 21, 2016


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      This means I can never enable the cache during development. Is that intended?
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
  


          
          
        
      
    

    



  
        
  
    
        
    
  


      
          
  
      
            Copy link

  
      
    
  

  
      

  
  Member


      

  

  
    
      

      
            nicolas-grekas
  

      

      

      


        Apr 21, 2016


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      you can, you just have to --env=prod

since there is no invalidation, enabling this cache in dev only creates WTFs :-)

We did a similar change for validation:

https://github.com/symfony/symfony/pull/18544/files#diff-0e793081ceb720201745c982a568903fL784
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
                 $container->setParameter(
                     'serializer.mapping.cache.prefix',
                     'serializer_'.$this->getKernelRootHash($container)
-          Expand Down