-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Security][CSRF] Double Submit Cookies CSRF prevention strategy #18333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d746f31
extend csrf token storage infrastructure
backbone87 e9573af
code style and feedback
backbone87 beed130
more codestyle fixes
backbone87 1cea0d2
remove @see
backbone87 a298be6
update suggestion notice in composer.json
backbone87 a533b0e
add a secureNamespace to SessionTokenStorageFactory for secure requests
backbone87 893fa0c
implement EventSubscriberInterface into CookieTokenStorageListener
backbone87 61b5483
add verification logic to CookieTokenStorage
backbone87 6e19ef9
rework CookieTokenStorage
backbone87 99dde3b
code style
backbone87 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
21 changes: 21 additions & 0 deletions
21
src/Symfony/Component/Security/Core/Exception/UnexpectedValueException.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Symfony package. | ||
| * | ||
| * (c) Fabien Potencier <fabien@symfony.com> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Symfony\Component\Security\Core\Exception; | ||
|
|
||
| /** | ||
| * Base UnexpectedValueException for the Security component. | ||
| * | ||
| * @author Oliver Hoff <oliver@hofff.com> | ||
| */ | ||
| class UnexpectedValueException extends \UnexpectedValueException implements ExceptionInterface | ||
| { | ||
| } |
58 changes: 58 additions & 0 deletions
58
src/Symfony/Component/Security/Csrf/TokenStorage/AbstractTokenStorageProxy.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Symfony package. | ||
| * | ||
| * (c) Fabien Potencier <fabien@symfony.com> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Symfony\Component\Security\Csrf\TokenStorage; | ||
|
|
||
| /** | ||
| * Forwards calls to another TokenStorageInterface. | ||
| * | ||
| * @author Oliver Hoff <oliver@hofff.com> | ||
| */ | ||
| abstract class AbstractTokenStorageProxy implements TokenStorageInterface | ||
| { | ||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function getToken($tokenId) | ||
| { | ||
| return $this->getProxiedTokenStorage()->getToken($tokenId); | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function setToken($tokenId, $token) | ||
| { | ||
| // TODO interface declares return void, use return stmt or not? | ||
| $this->getProxiedTokenStorage()->setToken($tokenId, $token); | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function removeToken($tokenId) | ||
| { | ||
| return $this->getProxiedTokenStorage()->removeToken($tokenId); | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function hasToken($tokenId) | ||
| { | ||
| return $this->getProxiedTokenStorage()->hasToken($tokenId); | ||
| } | ||
|
|
||
| /** | ||
| * @return TokenStorageInterface | ||
| */ | ||
| abstract protected function getProxiedTokenStorage(); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it makes sense to mark concrete public methods as final?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think final should only be used in very special cases when you absolutely rely on the implemented behavior and to keep the internal state of the class clean and valid, and this cannot be provided by subclasses (e.g. not being able to access private properties). Both is not the case here. Imagine someone wants to create a decorater that fixes the token ID to a certain value, using this class as a parent would not be possible with final methods.