Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Var-Dumper] added feature to set default nodes collapsed #18148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Var-Dumper] added feature to set default nodes collapsed
modify js htmldumper and add options to configure js
  • Loading branch information
MGDSoft committed Apr 2, 2016
commit 691d39e9dbd3826ace5895844c31d0edba6441d3
8 changes: 4 additions & 4 deletions 8 src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php
Original file line number Diff line number Diff line change
Expand Up @@ -133,12 +133,12 @@ protected function getDumpHeader()
return $this->dumpHeader;
}

$line = "<script>
$line = '<script>
Sfdump = window.Sfdump || (function (doc) {

var defaultOptions = ".json_encode($this->jsPropertiesDefault).";
var defaultOptions = '.json_encode($this->jsPropertiesDefault).';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the actual max depth is provided as argument to the Sfdump function, there is no need to put the default value here (and thus neither no need to handle any merging (extend))


";
';

$line .= <<<'EOHTML'

Expand Down Expand Up @@ -490,7 +490,7 @@ protected function dumpLine($depth, $endOfValue = false)
$this->line .= sprintf(
$this->dumpSuffix,
$this->dumpId,
$this->jsProperties ? ','. json_encode($this->jsProperties) : ''
$this->jsProperties ? ','.json_encode($this->jsProperties) : ''
);
}
$this->lastDepth = $depth;
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.