Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[DoctrineBridge][Form] Fix performance regression in EntityType #17990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[DoctrineBridge][Form] Fix performance regression in EntityType #17990

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c680579
[DoctrineBridge][Form] Fix performance regression in EntityType
kimlai Mar 2, 2016
470f319
[code review] only optimize if `choice_value` is either `null` or the…
kimlai Mar 3, 2016
aa3425e
[code review] only optimize if `choice_value` is our IdReader
kimlai Mar 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[code review] only optimize if choice_value is our IdReader
  • Loading branch information
@kimlai
kimlai committed Mar 3, 2016
commit aa3425e76b6f77633fdd1ace5bd582acf415a3ac
2 changes: 1 addition & 1 deletion 2 src/Symfony/Bridge/Doctrine/Form/ChoiceList/DoctrineChoiceLoader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ public function loadChoicesForValues(array $values, $value = null)

// Optimize performance in case we have an object loader and
// a single-field identifier
$optimize = null === $value || $isDefaultValue = is_array($value) && isset($value[0]) && $value[0] instanceof IdReader;
$optimize = null === $value || is_array($value) && $value[0] === $this->idReader;

if ($optimize && !$this->choiceList && $this->objectLoader && $this->idReader->isSingleId()) {
$unorderedObjects = $this->objectLoader->getEntitiesByIds($this->idReader->getIdField(), $values);
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.