ensure dump indentation to be greather than zero

symfony · xabbuh · Mar 1, 2016 · Mar 1, 2016 · fddc37e7409c170df7dd8c0815b4c040f90adacb · dosten
commit fddc37e7409c170df7dd8c0815b4c040f90adacb
diff --git a/src/Symfony/Component/Yaml/Dumper.php b/src/Symfony/Component/Yaml/Dumper.php
@@ -30,6 +30,10 @@ class Dumper
     */
    public function __construct($indentation = 4)
    {
+        if ($indentation < 1) {
+            throw new \InvalidArgumentException('The indentation must be greater than zero.');
+        }
+
        $this->indentation = $indentation;
    }


diff --git a/src/Symfony/Component/Yaml/Tests/DumperTest.php b/src/Symfony/Component/Yaml/Tests/DumperTest.php
@@ -347,6 +347,24 @@ public function testDumpMultiLineStringAsScalarBlock()

        $this->assertSame(file_get_contents(__DIR__.'/Fixtures/multiple_lines_as_literal_block.yml'), $this->dumper->dump($data, 3, 0, Yaml::DUMP_MULTI_LINE_LITERAL_BLOCK));
    }
+
+    /**
+     * @expectedException \InvalidArgumentException
+     * @expectedExceptionMessage The indentation must be greater than zero
+     */
+    public function testZeroIndentationInConstructorThrowsException()
+    {
+        new Dumper(0);
+    }
+
+    /**
+     * @expectedException \InvalidArgumentException
+     * @expectedExceptionMessage The indentation must be greater than zero
+     */
+    public function testNegativeIndentationInConstructorThrowsException()
+    {
+        new Dumper(-4);
+    }
 }

 class A
-Original file line number
+Diff line change
@@ -30,6 +30,10 @@ class Dumper
          */
         public function __construct($indentation = 4)
         {
+            if ($indentation < 1) {
+                throw new \InvalidArgumentException('The indentation must be greater than zero.');
             Copy link

  
      
    
  

  
      

  
    Contributor


      

  

  
    
      

      
            dosten
  

      

      

      


        Mar 1, 2016


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      The indentation can be a float number like 3.14? or should ensure that the indentation is a natural number?
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
  


          
          
        
      
    

    



  
        
  
    
        
    
  


      
          
  
      
            Copy link

  
      
    
  

  
      

  
  Member


      

  Author


  

  
    
      

      
            xabbuh
  

      

      

      


        Mar 1, 2016


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      The docblock states that the argument must be an integer and we don't do scalar type checks in Symfony.
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
+            }
             $this->indentation = $indentation;
         }
-          Expand Down