Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[CS] PHPUnit dedicate assert fixer acceptance test #17872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2016

Conversation

SpacePossum
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
License MIT

The goal of this PR is not to have it merge, but to check with SF community if a new Fixer (PHP-CS-Fixer/PHP-CS-Fixer#1792) should be added to the set of Symfony fixers (at PHP-CS-Fixer).

@javiereguiluz
Copy link
Member

My 2 cents: I love the assertFileExists() and assertFileNotExists() ... but I don't like the assertInternalType(). I wish it was called assertType().

@fabpot
Copy link
Member

fabpot commented Feb 21, 2016

LGTM 👍

@SpacePossum
Copy link
Contributor Author

nice :)

offtopic:
@javiereguiluz I agree, don't know why they picked that method name. I created a trait with some aliases https://github.com/GeckoPackages/GeckoPHPUnit#scalarasserttrait (not useful for SF, but maybe for a little project of your own ;) )

@fabpot
Copy link
Member

fabpot commented Feb 22, 2016

Thank you @SpacePossum.

@fabpot fabpot merged commit 7aff7f4 into symfony:2.3 Feb 22, 2016
fabpot added a commit that referenced this pull request Feb 22, 2016
…ePossum)

This PR was merged into the 2.3 branch.

Discussion
----------

[CS] PHPUnit dedicate assert fixer acceptance test

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| License       | MIT

The goal of this PR is _not_ to have it merge, but to check with SF community if a new Fixer (PHP-CS-Fixer/PHP-CS-Fixer#1792) should be added to the set of Symfony fixers (at PHP-CS-Fixer).

Commits
-------

7aff7f4 PhpUnitNoDedicateAssertFixer results
@SpacePossum SpacePossum deleted the 2_3_PhpUnitNoDedicateAssertFixer branch February 22, 2016 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.