[CS] PHPUnit dedicate assert fixer acceptance test #17872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My 2 cents: I love the |
|
LGTM 👍 |
|
nice :) offtopic: |
|
Thank you @SpacePossum. |
fabpot
added a commit
that referenced
this pull request
Feb 22, 2016
…ePossum) This PR was merged into the 2.3 branch. Discussion ---------- [CS] PHPUnit dedicate assert fixer acceptance test | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | License | MIT The goal of this PR is _not_ to have it merge, but to check with SF community if a new Fixer (PHP-CS-Fixer/PHP-CS-Fixer#1792) should be added to the set of Symfony fixers (at PHP-CS-Fixer). Commits ------- 7aff7f4 PhpUnitNoDedicateAssertFixer results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is not to have it merge, but to check with SF community if a new Fixer (PHP-CS-Fixer/PHP-CS-Fixer#1792) should be added to the set of Symfony fixers (at PHP-CS-Fixer).