[VarDumper] fix PHP 7 tests #17775
Closed
[VarDumper] fix PHP 7 tests #17775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88737a6 to
cfd2bdf
Compare
|
I propose to make that patch simpler: just don't test for timed_out, blocked and eof keys, they don't provide any specific behavior coverage I think |
|
Well, but they are part of the output. Do you wanna cover this with a regex? Or is it possible to let the dumpers not dump these information? |
|
It's possible to tell phpunit to ignore these: just remove the lines in the expected format, the |
|
I see, I'll try that tonight. If you happen to find some time before, feel free to take this over. |
|
Replaced by #17781 |
fabpot
added a commit
that referenced
this pull request
Feb 13, 2016
This PR was merged into the 2.7 branch. Discussion ---------- [VarDumper] Fix tests on PHP 7 | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Supersedes #17775 Commits ------- 5d433ca [VarDumper] Fix tests on PHP 7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is only a short term solution. We should rather find a way to have the tests not rely on the order of the dumped properties or ensure in the component that the order does not change. But this at least makes our test suite reliable again.