Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[DEPRECATION] : deprecated support for Traversable in method ResizeFormListener::PreSubmit #17732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

[DEPRECATION] : deprecated support for Traversable in method ResizeFormListener::PreSubmit #17732

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b0beab9
[DEPRECATION] : deprecated support for Traversable in method
ybensacq Feb 8, 2016
39f7f54
[DEPRECATION] : deprecated support for Traversable in method
ybensacq Feb 8, 2016
d666f3e
[DEPRECATION] : deprecated support for Traversable in method
ybensacq Feb 8, 2016
042b899
[DEPRECATION] : deprecated support for Traversable in method
ybensacq Feb 8, 2016
188e780
[DEPRECATION] : deprecated support for Traversable in method
ybensacq Feb 8, 2016
554307c
fix BC breack
ybensacq Feb 9, 2016
59ff581
update Documentation files
ybensacq Feb 9, 2016
176d30d
Fix backticks in .md
ybensacq Feb 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[DEPRECATION] : deprecated support for Traversable in method
  • Loading branch information
@ybensacq
ybensacq committed Feb 8, 2016
commit 39f7f548294d011b5e874af6063bb417f7b8d4b7
1 change: 0 additions & 1 deletion 1 src/Symfony/Component/Form/Extension/Core/EventListener/ResizeFormListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ public function preSubmit(FormEvent $event)
$form = $event->getForm();
$data = $event->getData();


if ($data instanceof \Traversable){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space before the curly brace and IMO this should be $data instanceof \Traversable && $data instanceof \ArrayAccess because if someone pass an object that implements Traversable but not ArrayAccess the deprecation will be thrown but the $data will be reseted to an empty array.

@trigger_error('Support for Traversable is deprecated since version 3.1 and will be removed in 4.0. You should not use it anymore.', E_USER_DEPRECATED);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be OK for data init as array, but an object implementing only \Traversable would trigger the notice but was not supported before unless supporting \ArrayAccess too.

What about 'Support for objects implementing both \Traversable and \ArrayAccess is deprecated since version 3.1 and will be removed in 4.0. You should not use it anymore.' ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say: Use an array instead. instead of You should not use it anymore..

}
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.