[Yaml] properly parse lists in object maps #17729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Feb 8, 2016
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #17709, #17710, #17711 |
| License | MIT |
| Doc PR |
- do not cast parsed sequences to objects
- properly handle numeric mapping keys
|
👍 |
| @@ -303,8 +303,14 @@ public function parse($value, $exceptionOnInvalidType = false, $objectSupport = | ||
| mb_internal_encoding($mbEncoding); | ||
| } | ||
|
|
||
| if ($objectForMap && !is_object($data)) { | ||
| $data = (object) $data; |
There was a problem hiding this comment.
I don't understand why we made this change:
- $data = (object) $data;
+ $object = new \stdClass();
+
+ foreach ($data as $key => $value) {
+ $object->$key = $value;
+ }
+
+ $data = $object;There was a problem hiding this comment.
PHP behaves a bit different when it comes to numeric keys (see https://3v4l.org/dUGiM).
There was a problem hiding this comment.
@xabbuh thanks for the explanation!
c907339 to
81a164e
Compare
* do not cast parsed sequences to objects * properly handle numeric mapping keys
81a164e to
ee9ca93
Compare
|
👍 Status: reviewed |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Feb 14, 2016
This PR was merged into the 2.8 branch. Discussion ---------- [Yaml] properly parse lists in object maps | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17709, #17710, #17711 | License | MIT | Doc PR | * do not cast parsed sequences to objects * properly handle numeric mapping keys Commits ------- ee9ca93 [Yaml] properly parse lists in object maps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.