Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[FrameworkBundle] Register the DataUriNormalizer #17631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented Jan 31, 2016

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR todo

@xabbuh
Copy link
Member

xabbuh commented Feb 3, 2016

@dunglas Did we already make a decision on how to ensure the proper Serializer component version?

@dunglas
Copy link
Member Author

dunglas commented Feb 3, 2016

IIRC, no. The easiest way is to register it in the extension with a call to class_exist. What do you think?

@dunglas
Copy link
Member Author

dunglas commented Feb 21, 2016

ping @symfony/deciders

@weaverryan
Copy link
Member

👍

Maybe it should be configurable... but I can't think of when you would not want it (except for really optimizing for performance to not include this instantiated object) and we could add that later.

@mcfedr
Copy link
Contributor

mcfedr commented Feb 22, 2016

This is similar situation to #17603 where I have put a composer conflicts to make sure it has the correct version of the serializer component.
My question would be, is there any reason for someone using version 3.0 of the component to want to upgrade the framework bundle but keep the old serializer component?

@dunglas
Copy link
Member Author

dunglas commented Feb 22, 2016

@mcfedr Probably. The basic use case is a dependency requiring an old version of the component.

@dunglas
Copy link
Member Author

dunglas commented Feb 22, 2016

@weaverryan for optimizations like that, a compiler pass can be used to remove unnecessary normalizers.

@mcfedr
Copy link
Contributor

mcfedr commented Feb 22, 2016

Most people would likely have a ^3.0.0 or similar dependancy.. Basically I'm not really fighting for either option being better, but I would be maybe more inclined to use the conflict to avoid having to introduce work arounds for old versions, which tend to make the code less clear.

@fabpot
Copy link
Member

fabpot commented Feb 22, 2016

Thank you @dunglas.

@fabpot fabpot closed this in 9d48b0f Feb 22, 2016
@fabpot fabpot mentioned this pull request May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.