-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[FrameworkBundle] Register the DataUriNormalizer #17631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dunglas
commented
Jan 31, 2016
Q | A |
---|---|
Bug fix? | no |
New feature? | yes |
BC breaks? | no |
Deprecations? | no |
Tests pass? | yes |
Fixed tickets | n/a |
License | MIT |
Doc PR | todo |
@dunglas Did we already make a decision on how to ensure the proper Serializer component version? |
IIRC, no. The easiest way is to register it in the extension with a call to class_exist. What do you think? |
edde6c2
to
e6ada5e
Compare
ping @symfony/deciders |
👍 Maybe it should be configurable... but I can't think of when you would not want it (except for really optimizing for performance to not include this instantiated object) and we could add that later. |
This is similar situation to #17603 where I have put a composer |
@mcfedr Probably. The basic use case is a dependency requiring an old version of the component. |
@weaverryan for optimizations like that, a compiler pass can be used to remove unnecessary normalizers. |
Most people would likely have a |
Thank you @dunglas. |