Change few occurences of a public setUp() method to protected #17567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jakzal
commented
Jan 27, 2016
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
| #17566 for the 2.8 branch. Occurrences fixed in #17566 are not included here. |
|
👍 There are still few occurrences in |
|
@dunglas I'm going out to have some lunch. If you haven't fixed it by the time I come back, I'll do it ;) |
|
Thank you @jakzal. |
fabpot
added a commit
that referenced
this pull request
Jan 27, 2016
…ected (jakzal) This PR was merged into the 2.8 branch. Discussion ---------- Change few occurences of a public setUp() method to protected | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - #17566 for the 2.8 branch. Occurrences fixed in #17566 are not included here. Commits ------- 0a883a9 Change few occurences of a public setUp() method to protected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.