Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update UPGRADE-3.0 with correct Voter details #17507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2016
Merged

Update UPGRADE-3.0 with correct Voter details #17507

merged 1 commit into from
Jan 27, 2016

Conversation

jbafford
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? n/a
Fixed tickets
License MIT
Doc PR

AbstractVoter was removed, but the upgrade instructions to use Voter were not complete and continued to reference AbstractVoter.

@wouterj
Copy link
Member

wouterj commented Jan 23, 2016

I propose to merge "The AbstractVoter class was removed in favor of the new Voter class." and the edited upgrade notes to the upgrade note in the 2.8 file:

  • The AbstractVoter class was deprecated. Instead, extend the Voter class and move your voting logic in the supports($attribute, $subject) and voteOnAttribute($attribute, $object, TokenInterface $token) methods.

Status: Needs work

@jbafford
Copy link
Contributor Author

@wouterj Just to be clear: you'd like me to copy the relevant section from the 3.0 upgrade to the 2.8 section so it's available in both places?

@wouterj
Copy link
Member

wouterj commented Jan 23, 2016

@jbafford what I mean updating the UPGRADE-3.0.md file to be more similar to the UPGRADE-2.8.md file. I think the note from the 2.8 upgrade guide is nicer.

@fabpot
Copy link
Member

fabpot commented Jan 27, 2016

@jbafford Can you make the needed changes so that we can merge this before the next 3.0 patch release? Thank you.

@jbafford
Update UPGRADE-3.0 with correct Voter details
7b2a538 
AbstractVoter was removed, but the upgrade instructions to use Voter were not complete and continued to reference AbstractVoter.
@jbafford
Copy link
Contributor Author

I've updated the PR by reorganizing the AbstractVoter/VoterInterface notes so that they're all next to each other and the example, and improved the language and the example slightly using the 2.8 upgrade file as a base. Will this work?

@fabpot
Copy link
Member

fabpot commented Jan 27, 2016

Thank you @jbafford.

@fabpot fabpot merged commit 7b2a538 into symfony:2.8 Jan 27, 2016
fabpot added a commit that referenced this pull request Jan 27, 2016
@fabpot
minor #17507 Update UPGRADE-3.0 with correct Voter details (jbafford)
5f5f4aa 
This PR was merged into the 2.8 branch.

Discussion
----------

Update UPGRADE-3.0 with correct Voter details

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | n/a
| Fixed tickets |
| License       | MIT
| Doc PR        |

AbstractVoter was removed, but the upgrade instructions to use Voter were not complete and continued to reference AbstractVoter.

Commits
-------

7b2a538 Update UPGRADE-3.0 with correct Voter details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbafford @wouterj @fabpot @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.