[FrameworkBundle] Throw for missing container extensions #17486
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This covers cases when a bundle does not have an extension, which lead to FatalErrorException with ```Call to a member function getAlias() on null```
|
Looks good to me 👍 |
|
Thank you @kix. |
fabpot
added a commit
that referenced
this pull request
Jan 25, 2016
…kix) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #17486). Discussion ---------- [FrameworkBundle] Throw for missing container extensions | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | none This covers the case when an existing bundle does not have an extension, and its config is dumped. Before, calling `app/console config:dump` on such bundle lead to FatalErrorException with ```Call to a member function getAlias() on null```, now we process such cases and throw an exception with some explanatory text. Commits ------- 884368e Throw for missing container extensions
|
Thanks for the merge! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers the case when an existing bundle does not have an extension, and its config is dumped. Before, calling
app/console config:dumpon such bundle lead to FatalErrorException withCall to a member function getAlias() on null, now we process such cases and throw an exception with some explanatory text.