Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Form] fix #15544 when a collection type attribute "required" is false, "prototype" should too #16959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add test
- las test is failing when the collection is set to “required” =>
false, the prototype is required.
  • Loading branch information
HeahDude committed Dec 11, 2015
commit bbc17143b97bfc5f4998833bf1a20ef40a9e684f
Original file line number Diff line number Diff line change
Expand Up @@ -195,4 +195,30 @@ public function testPrototypeDefaultLabel()

$this->assertSame('__test__label__', $form->createView()->vars['prototype']->vars['label']);
}

public function testPrototypeDefaultRequired()
{
$form = $this->factory->create('collection', array(), array(
'type' => 'file',
'allow_add' => true,
'prototype' => true,
'prototype_name' => '__test__',
));

$this->assertTrue($form->createView()->vars['prototype']->vars['required']);
}

public function testPrototypeSetNotRequired()
{
$form = $this->factory->create('collection', array(), array(
'type' => 'file',
'allow_add' => true,
'prototype' => true,
'prototype_name' => '__test__',
'required' => false,
));

$this->assertFalse($form->createView()->vars['required'], 'collection is not required');
$this->assertFalse($form->createView()->vars['prototype']->vars['required'], '"prototype" should not be required');
}
}
Morty Proxy This is a proxified and sanitized view of the page, visit original site.