[Translation][Writer] avoid calling setBackup if the dumper is not FileDumper #16912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aitboudad
commented
Dec 8, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | ~ |
| License | MIT |
| Doc PR | n/a |
| @@ -45,7 +46,9 @@ public function addDumper($format, DumperInterface $dumper) | ||
| public function disableBackup() | ||
| { | ||
| foreach ($this->dumpers as $dumper) { | ||
| $dumper->setBackup(false); | ||
| if ($dumper instanceof FileDumper) { |
There was a problem hiding this comment.
What about using method_exists() here instead to support users who create their own dumpers?
b4f2a7c to
6c700c1
Compare
|
👍 Status: Reviewed |
| @@ -13,6 +13,7 @@ | ||
|
|
||
| use Symfony\Component\Translation\MessageCatalogue; | ||
| use Symfony\Component\Translation\Dumper\DumperInterface; | ||
| use Symfony\Component\Translation\Dumper\FileDumper; |
There was a problem hiding this comment.
This should now be removed again.
6c700c1 to
6c43dc0
Compare
|
|
||
| $writer = new TranslationWriter(); | ||
| $writer->addDumper('test', $dumper); | ||
| $writer->writeTranslations(new MessageCatalogue([]), 'test'); |
There was a problem hiding this comment.
Oh, I missed that but tests are failing: We cannot use the short array syntax here.
There was a problem hiding this comment.
it should work now, I'll pay more attention next time ;)
|
Status: Needs work |
… instance of FileDumper.
6c43dc0 to
369b2d4
Compare
|
Would it make sense to create an interface for setBackup on 3.1? method_exists is quite fragile imho |
|
Thank you @aitboudad. |
fabpot
added a commit
that referenced
this pull request
Jan 25, 2016
…r is not FileDumper (aitboudad) This PR was merged into the 2.7 branch. Discussion ---------- [Translation][Writer] avoid calling setBackup if the dumper is not FileDumper | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | n/a Commits ------- 369b2d4 [Translation][Writer] avoid calling setBackup if the dumper is not an instance of FileDumper.
Merged
fabpot
added a commit
that referenced
this pull request
Apr 1, 2016
This PR was merged into the 3.1-dev branch. Discussion ---------- [Translation] deprecate the backup feature | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #16912 (comment) | License | MIT | Doc PR | Commits ------- 6c3ddf1 [Translation] deprecate the backup feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.