[Form+SecurityBundle] Trigger deprecation for csrf_provider+intention options #16704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ->children() | ||
| ->scalarNode('csrf_provider')->cannotBeEmpty()->end() | ||
| ->scalarNode('csrf_token_generator')->cannotBeEmpty()->end() | ||
| ->end() |
There was a problem hiding this comment.
intention should be renamed to csrf_token_id too
There was a problem hiding this comment.
I removed the beforeNormalizer for "intention": there is not "intention" in this configuration section
44e21fc to
62eba7c
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Nov 27, 2015
…r+intention options (nicolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [Form+SecurityBundle] Trigger deprecation for csrf_provider+intention options | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - ping @stof Commits ------- 62eba7c [Form+SecurityBundle] Trigger deprecation for csrf_provider+intention options
| @@ -74,8 +74,8 @@ public function testCsrfAliases() | ||
| 'firewalls' => array( | ||
| 'stub' => array( | ||
| 'logout' => array( | ||
| 'csrf_provider' => 'a_token_generator', |
There was a problem hiding this comment.
I think we should keep a configuration with csrf_provider in a legacy test to ensure not to introduce BC breaks in 2.8 patch releases in the future.
There was a problem hiding this comment.
@xabbuh can you do it please?
nicolas-grekas
added a commit
that referenced
this pull request
Nov 28, 2015
…(xabbuh) This PR was merged into the 2.8 branch. Discussion ---------- [SecurityBundle] test legacy CSRF configuration options | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16704 | License | MIT | Doc PR | Commits ------- 444b6ef test legacy CSRF configuration options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @stof