Added the renamed options of the collection type to the upgrade information #16659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
peterrehm
commented
Nov 25, 2015
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
|
|
||
| * The option "type" of the CollectionType has been renamed to "entry_type". | ||
| The usage of the option "type" is deprecated as of Symfony 2.8 and will be | ||
| removed in Symfony 3.0. As a value for the option you need to provide now |
There was a problem hiding this comment.
"should" provide (instead of "need") as its not mandatory in 2.8 yet. And grammar: "As a value for the option you should to provide the fully-qualified class name (FQCN) now as well."
|
Thanks, has been updated. |
|
|
||
| * The option "type" of the CollectionType has been renamed to "entry_type". | ||
| The usage of the option "type" is deprecated and will be removed in Symfony 3.0. | ||
| As a value for the option you need to provide now the fully-qualified class name |
There was a problem hiding this comment.
Sorry, did not see that comment, updated now.
|
There's one little extra period, but 👍 Thanks for testing @peterrehm! |
|
Fixed... |
|
Can you also add a paragraph to |
|
Updated. |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @peterrehm. |
fabpot
added a commit
that referenced
this pull request
Nov 30, 2015
…upgrade information (peterrehm) This PR was merged into the 2.8 branch. Discussion ---------- Added the renamed options of the collection type to the upgrade information | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 7aac273 Added the renamed options of the collection type to the upgrade information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.