Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Console] progress bar fix #16490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

[Console] progress bar fix #16490

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4edfabc
[Console] ProgressBar - adjust to the window width (static)
TomasVotruba Nov 6, 2015
3a55e6b
ProgressBar: use Application method getTerminalDimensions() to get te…
TomasVotruba Nov 14, 2015
77b92da
TerminalDimensionsProvider added
TomasVotruba Nov 14, 2015
6a77dbe
Application: make use of TerminalDimensionsProvider
TomasVotruba Nov 14, 2015
066f391
ProgressBar: make use of TerminalDimensionsProvider
TomasVotruba Nov 14, 2015
efb2b7d
TerminalDimensionsProvider: use old array style, add test helper method
TomasVotruba Nov 14, 2015
0dea4e8
coding standard fixes
TomasVotruba Nov 14, 2015
846f1be
TerminalDimensionsProvider test fixes
TomasVotruba Nov 14, 2015
cc14c56
cs
TomasVotruba Nov 15, 2015
ac3ad46
ProgressBar: make sure width is positive number
TomasVotruba Nov 15, 2015
c89d24f
ProgressBar: decouple building line to standalone method, better adju…
TomasVotruba Nov 15, 2015
cf0e411
ProgressBar: fix tests
TomasVotruba Nov 15, 2015
eb8a58d
[Console] drop TerminalDimensionsProviderInterface
TomasVotruba Mar 5, 2016
885e4ea
[Console] TerminalDimensionsProvider - make PHP 5.3 compatible
TomasVotruba Mar 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
coding standard fixes
  • Loading branch information
@TomasVotruba
TomasVotruba committed Nov 14, 2015
commit 0dea4e8dba8af645dfbe3d81a957ce14cc4ace22
6 changes: 3 additions & 3 deletions 6 src/Symfony/Component/Console/Application.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@ class Application
private $terminalDimensionsProvider;

/**
* @param string $name The name of the application
* @param string $version The version of the application
* @param TerminalDimensionsProviderInterface $terminalDimensionsProvider
* @param string $name The name of the application
* @param string $version The version of the application
* @param TerminalDimensionsProviderInterface $terminalDimensionsProvider
*/
public function __construct($name = 'UNKNOWN', $version = 'UNKNOWN', TerminalDimensionsProviderInterface $terminalDimensionsProvider = null)
{
Expand Down
6 changes: 3 additions & 3 deletions 6 src/Symfony/Component/Console/Helper/ProgressBar.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ class ProgressBar
private $terminalDimensionsProvider;

/**
* @param OutputInterface $output An OutputInterface instance
* @param int $max Maximum steps (0 if unknown)
* @param TerminalDimensionsProviderInterface $terminalDimensionsProvider
* @param OutputInterface $output An OutputInterface instance
* @param int $max Maximum steps (0 if unknown)
* @param TerminalDimensionsProviderInterface $terminalDimensionsProvider
*/
public function __construct(OutputInterface $output, $max = 0, TerminalDimensionsProviderInterface $terminalDimensionsProvider = null)
{
Expand Down
4 changes: 2 additions & 2 deletions 4 src/Symfony/Component/Console/Terminal/TerminalDimensionsProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ private function getConsoleMode()

$descriptorspec = array(
1 => array('pipe', 'w'),
2 => array('pipe', 'w')
2 => array('pipe', 'w'),
);
$process = proc_open('mode CON', $descriptorspec, $pipes, null, null, array('suppress_errors' => true));
if (is_resource($process)) {
Expand Down Expand Up @@ -122,7 +122,7 @@ private function getSttyColumns()

$descriptorspec = array(
1 => array('pipe', 'w'),
2 => array('pipe', 'w')
2 => array('pipe', 'w'),
);

$process = proc_open('stty -a | grep columns', $descriptorspec, $pipes, null, null, array('suppress_errors' => true));
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.