[VarDumper] replace VarDumperTestCase by trait

symfony · nicolas-grekas · Nov 5, 2015 · Nov 28, 2014 · Nov 1, 2015 · Nov 4, 2015
commit 230990188db46ee00a514db0049d279d8012b8f0
diff --git a/src/Symfony/Component/VarDumper/Test/VarDumperTestCase.php b/src/Symfony/Component/VarDumper/Test/VarDumperTestCase.php
diff --git a/src/Symfony/Component/VarDumper/Tests/Caster/CasterTest.php b/src/Symfony/Component/VarDumper/Tests/Caster/CasterTest.php
@@ -12,13 +12,15 @@
 namespace Symfony\Component\VarDumper\Tests\Caster;

 use Symfony\Component\VarDumper\Caster\Caster;
-use Symfony\Component\VarDumper\Test\VarDumperTestCase;
+use Symfony\Component\VarDumper\Test\VarDumperTestTrait;

 /**
 * @author Nicolas Grekas <p@tchwork.com>
 */
-class CasterTest extends VarDumperTestCase
+class CasterTest extends \PHPUnit_Framework_TestCase
 {
+    use VarDumperTestTrait;
+
    private $referenceArray = array(
        'null' => null,
        'empty' => false,

diff --git a/src/Symfony/Component/VarDumper/Tests/Caster/ReflectionCasterTest.php b/src/Symfony/Component/VarDumper/Tests/Caster/ReflectionCasterTest.php
@@ -11,14 +11,16 @@

 namespace Symfony\Component\VarDumper\Tests\Caster;

-use Symfony\Component\VarDumper\Test\VarDumperTestCase;
+use Symfony\Component\VarDumper\Test\VarDumperTestTrait;
 use Symfony\Component\VarDumper\Tests\Fixtures\GeneratorDemo;

 /**
 * @author Nicolas Grekas <p@tchwork.com>
 */
-class ReflectionCasterTest extends VarDumperTestCase
+class ReflectionCasterTest extends \PHPUnit_Framework_TestCase
 {
+    use VarDumperTestTrait;
+
    public function testReflectionCaster()
    {
        $var = new \ReflectionClass('ReflectionClass');

diff --git a/src/Symfony/Component/VarDumper/Tests/Caster/SplCasterTest.php b/src/Symfony/Component/VarDumper/Tests/Caster/SplCasterTest.php
@@ -11,13 +11,15 @@

 namespace Symfony\Component\VarDumper\Tests\Caster;

-use Symfony\Component\VarDumper\Test\VarDumperTestCase;
+use Symfony\Component\VarDumper\Test\VarDumperTestTrait;

 /**
 * @author Grégoire Pineau <lyrixx@lyrixx.info>
 */
-class SplCasterTest extends VarDumperTestCase
+class SplCasterTest extends \PHPUnit_Framework_TestCase
 {
+    use VarDumperTestTrait;
+
    public function getCastFileInfoTests()
    {
        return array(

diff --git a/src/Symfony/Component/VarDumper/Tests/CliDumperTest.php b/src/Symfony/Component/VarDumper/Tests/CliDumperTest.php
@@ -13,13 +13,15 @@

 use Symfony\Component\VarDumper\Cloner\VarCloner;
 use Symfony\Component\VarDumper\Dumper\CliDumper;
-use Symfony\Component\VarDumper\Test\VarDumperTestCase;
+use Symfony\Component\VarDumper\Test\VarDumperTestTrait;

 /**
 * @author Nicolas Grekas <p@tchwork.com>
 */
-class CliDumperTest extends VarDumperTestCase
+class CliDumperTest extends \PHPUnit_Framework_TestCase
 {
+    use VarDumperTestTrait;
+
    public function testGet()
    {
        require __DIR__.'/Fixtures/dumb-var.php';

diff --git a/src/Symfony/Component/VarDumper/Tests/Test/VarDumpTestTraitRequire54.php b/src/Symfony/Component/VarDumper/Tests/Test/VarDumpTestTraitRequire54.php
diff --git a/src/Symfony/Component/VarDumper/Tests/Test/VarDumpTestTraitTest.php b/src/Symfony/Component/VarDumper/Tests/Test/VarDumpTestTraitTest.php
@@ -9,8 +9,32 @@
 * file that was distributed with this source code.
 */

-// Skipping trait tests for PHP < 5.4
-if (version_compare(PHP_VERSION, '5.4.0-dev', '>=')) {
-    require 'VarDumpTestTraitRequire54.php';
-}
+namespace Symfony\Component\VarDumper\Tests\Test;
+
+use Symfony\Component\VarDumper\Test\VarDumperTestTrait;
+
+class VarDumperTestTraitTest extends \PHPUnit_Framework_TestCase
+{
+    use VarDumperTestTrait;

+    public function testItComparesLargeData()
+    {
+        $howMany = 700;
+        $data = array_fill_keys(range(0, $howMany), array('a', 'b', 'c', 'd'));
+
+        $expected = sprintf("array:%d [\n", $howMany + 1);
+        for ($i = 0; $i <= $howMany; ++$i) {
+            $expected .= <<<EODUMP
+  $i => array:4 [
+    0 => "a"
+    1 => "b"
+    2 => "c"
+    3 => "d"
+  ]\n
+EODUMP;
+        }
+        $expected .= "]\n";
+
+        $this->assertDumpEquals($expected, $data);
+    }
+}
-Original file line number
+Diff line change
@@ -9,8 +9,32 @@
      * file that was distributed with this source code.
      */
-    // Skipping trait tests for PHP < 5.4
-    if (version_compare(PHP_VERSION, '5.4.0-dev', '>=')) {
-        require 'VarDumpTestTraitRequire54.php';
-    }
+    namespace Symfony\Component\VarDumper\Tests\Test;
+    use Symfony\Component\VarDumper\Test\VarDumperTestTrait;
+    class VarDumperTestTraitTest extends \PHPUnit_Framework_TestCase
             Copy link

  
      
    
  

  
      

  
  Member


      

  

  
    
      

      
            nicolas-grekas
  

      

      

      


        Nov 4, 2015


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      a mistake that was here before but could be fixed here: the name of the file is wrong (VarDumper)
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
  


          
          
        
      
    

    



  
        
  
    
        
    
  


      
          
  
      
            Copy link

  
      
    
  

  
      

  
    Contributor


      

  Author


  

  
    
      

      
            Tobion
  

      

      

      


        Nov 4, 2015


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      done
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
+    {
+        use VarDumperTestTrait;
+        public function testItComparesLargeData()
+        {
+            $howMany = 700;
+            $data = array_fill_keys(range(0, $howMany), array('a', 'b', 'c', 'd'));
+            $expected = sprintf("array:%d [\n", $howMany + 1);
+            for ($i = 0; $i <= $howMany; ++$i) {
+                $expected .= <<<EODUMP
+      $i => array:4 [
+=> "a"
+=> "b"
+=> "c"
+=> "d"
+      ]\n
+    EODUMP;
+            }
+            $expected .= "]\n";
+            $this->assertDumpEquals($expected, $data);
+        }
+    }