[SecurityBundle] remove incompatible Twig version #16389
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the SecurityBundle is not compatible with Twig 2.0 as it is missing the implementation of the `Twig_Extension_InitRuntimeInterface`. Thus, `initRuntime()` would not be called with Twig 2.0 anymore.
|
Probably just came across the same issue. fails with: This PR fixes it. |
|
I'm having the same problem, so thanks 👍 |
This was referenced Oct 30, 2015
|
Twig 1.23 has been released yesterday. |
|
Ah, well, missed that. In this case we should merge #16331 instead of course. |
|
Thanks! |
|
Mmm, the build is still broken: https://travis-ci.org/symfony/symfony/jobs/88382131#L2674 Or does it wait on merging 2.3 branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the SecurityBundle is not compatible with Twig 2.0 as it is
missing the implementation of the
Twig_Extension_InitRuntimeInterface.Thus,
initRuntime()would not be called with Twig 2.0 anymore.This should make the Travis builds green again and should be reverted when Twig 1.23 is released (can be done with #16331).