[Translation] Allow to escape pipe #15206
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,7 +51,7 @@ class MessageSelector | ||
| */ | ||
| public function choose($message, $number, $locale) | ||
| { | ||
| $parts = explode('|', $message); | ||
| $parts = preg_split('/(?<!\\\\)\|/', $message) |
There was a problem hiding this comment.
But it doesn't allow to escape backslash itself.
There was a problem hiding this comment.
This should be enough for any case:
$parts = array_map(function($value){
return str_replace('\|','|',str_replace('\\\\','\\',$value));
},preg_split( '/(?<![^\\\\]\\\\)\|/', $message));
It ignores escaped pipes, ignore escaped backslashes and after split it replaces escaped pipes to pipes and escaped backslashes to backslash.
there needs to be 4 backslashes to escape to one before a pipe though, but hey, it's a way.
There was a problem hiding this comment.
@emiliopedrollo I used your proposal see #17662
|
Wouldn't this cause a performance impact for 99% of the users while only 1% uses this weird case? |
|
You should add new test for that |
|
Closing as the fix wasn't as easy as I thought and I'm not the qualified regex dev to do it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for escaping the pipe character, so pipes can be used in strings passed to transchoice.