Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Feedback required] Fixed asset version strategy #15108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Feedback required] Fixed asset version strategy #15108

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
932f3d3
Do not cast asset package version to string
XWB Jun 26, 2015
15d5448
Use EmptyVersionStrategy in case asset package version is null
XWB Jun 26, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use EmptyVersionStrategy in case asset package version is null
  • Loading branch information
@XWB
XWB committed Jun 26, 2015
commit 15d5448ceb59f969cb2687d388e2f9674a1d623e
8 changes: 2 additions & 6 deletions 8 src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,12 +584,8 @@ private function registerAssetsConfiguration(array $config, ContainerBuilder $co

$namedPackages = array();
foreach ($config['packages'] as $name => $package) {
if (null === $package['version']) {
$version = $defaultVersion;
} else {
$format = $package['version_format'] ?: $config['version_format'];
$version = $this->createVersion($container, $package['version'], $format, $name);
}
$format = $package['version_format'] ?: $config['version_format'];
$version = $this->createVersion($container, $package['version'], $format, $name);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are changing the behavior of null here


$container->setDefinition('assets._package_'.$name, $this->createPackageDefinition($package['base_path'], $package['base_urls'], $version));
$namedPackages[$name] = new Reference('assets._package_'.$name);
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.