Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[3.0][FrameworkBundle] Add assets helper #14972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[3.0][FrameworkBundle] Add assets helper #14972

wants to merge 1 commit into from

Conversation

dosten
Copy link
Contributor

@dosten dosten commented Jun 14, 2015

Q A
Bug fix? yes
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
License MIT

This PR adds again the AssetsHelper removed in #13666 but without the BC layer. Without this helper we can't use the Asset component in a PHP template.
If all of us agree with this, we should fix the UPGRADE-2.7.md file updated in #14940

@dosten
Copy link
Contributor Author

dosten commented Jun 14, 2015

Hmm Travis didn't run in this PR.

@dosten dosten mentioned this pull request Jun 14, 2015
Closed
@wouterj
Copy link
Member

wouterj commented Jun 14, 2015

Please be aware that there is a very high change that PHP templating support will be removed from core in Symfony 3.

@dosten
Copy link
Contributor Author

dosten commented Jun 14, 2015

Yes, i'm aware of that, but while we discuss if the templating support is removed or not i want to keep this here.

@peterrehm
Copy link
Contributor

And this it the wrong helper IMHO, if you look at the docs http://symfony.com/doc/current/components/templating/helpers/assetshelper.html the class Symfony\Component\Templating\Helper\AssetsHelper seems to be the important one. So due to the refactoring in the Asset component I would assume if php templating support remains, a helper should be placed in that Component.

@peterrehm
Copy link
Contributor

Also again I think the service will be replaced anyway, the discussion here is just about the helper.

I would recommend to close this PR here and continue the discussion in #14956

@dosten
Copy link
Contributor Author

dosten commented Jun 14, 2015

IMO instead of continue the discussion here or #14956 we should continue the discussion in #12897

@dosten
Copy link
Contributor Author

dosten commented Jun 15, 2015

Closing this in favor of drop the Templating component.

@dosten dosten closed this Jun 15, 2015
@dosten dosten deleted the framework-bundle/add-assets-helper branch June 15, 2015 17:25
@wouterj
Copy link
Member

wouterj commented Dec 16, 2015

This should be reopened again. There currently is PHP templating support in Symfony 3 (dropping it was reverted), but there all helpers related to assets are removed.

@dosten dosten restored the framework-bundle/add-assets-helper branch December 17, 2015 02:09
@dosten dosten reopened this Dec 17, 2015
@dosten
Copy link
Contributor Author

dosten commented Dec 17, 2015

@wouterj I'm going to see if I can restore al the code related to the Templating component, but we should merge this in 3.1 or in 3.0 as a bug fix?

@dosten dosten closed this Dec 17, 2015
@dosten dosten deleted the framework-bundle/add-assets-helper branch December 17, 2015 03:39
@dosten dosten mentioned this pull request Dec 17, 2015
Merged
@dosten
Copy link
Contributor Author

dosten commented Dec 17, 2015

closed in favour of #17041

fabpot added a commit that referenced this pull request Jan 19, 2016
@fabpot
bug #17041 [FrameworkBundle] Added the assets helper again (dosten)
98f86c0 
This PR was merged into the 3.0 branch.

Discussion
----------

[FrameworkBundle] Added the assets helper again

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

This PR is a follow up of #14972, we deprecated and removed the AssetsHelper in 2.7/3.0 doing impossible to use the Asset component and the PHP templates together, I've submitted this PR to be merged in 3.0 because IMO this is a bug fix, but we documented the deprecation and removal of the helper, what we should do here? (https://github.com/symfony/symfony/blob/3.0/UPGRADE-3.0.md#frameworkbundle and https://github.com/symfony/symfony/blob/2.8/UPGRADE-2.7.md#frameworkbundle)

cc/ @wouterj

Commits
-------

98cb838 Added the assets helper again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dosten @wouterj @peterrehm
Morty Proxy This is a proxified and sanitized view of the page, visit original site.