Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[DoctrineBridge] Fix DoctrineType #14929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2015
Merged

[DoctrineBridge] Fix DoctrineType #14929

merged 1 commit into from
Jun 10, 2015

Conversation

dosten
Copy link
Contributor

@dosten dosten commented Jun 9, 2015

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

Seems that a wrong merge breaks the DoctrineType. Because the minimum version in 3.0 is 5.5 we can use $this inside a closure.

@dosten
Copy link
Contributor Author

dosten commented Jun 9, 2015

See https://travis-ci.org/symfony/symfony/jobs/66126841 for an example of the failing tests.

@dosten
Copy link
Contributor Author

dosten commented Jun 9, 2015

The DoctrineBridge tests are now running ok.

@fabpot
Copy link
Member

fabpot commented Jun 10, 2015

Thank you @dosten.

@fabpot fabpot merged commit 0010452 into symfony:master Jun 10, 2015
fabpot added a commit that referenced this pull request Jun 10, 2015
This PR was merged into the 3.0-dev branch.

Discussion
----------

[DoctrineBridge] Fix DoctrineType

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Seems that a wrong merge breaks the `DoctrineType`. Because the minimum version in 3.0 is 5.5 we can use `$this` inside a closure.

Commits
-------

0010452 Fix DoctrineType
@dosten dosten deleted the fix-doctrine-type branch June 10, 2015 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.