[DoctrineBridge] Fix DoctrineType #14929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See https://travis-ci.org/symfony/symfony/jobs/66126841 for an example of the failing tests. |
|
The DoctrineBridge tests are now running ok. |
|
Thank you @dosten. |
fabpot
added a commit
that referenced
this pull request
Jun 10, 2015
This PR was merged into the 3.0-dev branch. Discussion ---------- [DoctrineBridge] Fix DoctrineType | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Seems that a wrong merge breaks the `DoctrineType`. Because the minimum version in 3.0 is 5.5 we can use `$this` inside a closure. Commits ------- 0010452 Fix DoctrineType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that a wrong merge breaks the
DoctrineType. Because the minimum version in 3.0 is 5.5 we can use$thisinside a closure.