Changed tooltip to expand all keybinding in OS X #14828
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand all keybinding is Cmd+click in OS X
|
👍 |
|
Though I failed to comply with pull request standards it's a small change, so you can just fix it with another commit. Sorry for the inconvenience. |
|
ping @nicolas-grekas |
| @@ -119,6 +119,9 @@ protected function getDumpHeader() | ||
| addEventListener = function (e, n, cb) { | ||
| e.addEventListener(n, cb, false); | ||
| }; | ||
|
|
||
| var isMac = navigator.platform.toUpperCase().indexOf('MAC') >= 0; |
There was a problem hiding this comment.
isMac temporary variable can be removed by merging this with the ternary check on the line below.
I'd also merge this new var declaration with the one above, eg. after idRx
|
Thank you @taylankasap, will be merged in #14855 |
fabpot
added a commit
that referenced
this pull request
Jun 4, 2015
… X (taylankasap) This PR was merged into the 2.7 branch. Discussion ---------- [VarDumper] Changed tooltip to expand-all keybinding in OS X | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14828 | License | MIT | Doc PR | - Commits ------- 8809362 [VarDumper] Changed tooltip to expand-all keybinding in OS X
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand all keybinding is Cmd+click in OS X